[Webkit-unassigned] [Bug 16693] Acid3 expects WebKit to raise exceptions for invalid qualified names

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 9 13:26:49 PST 2008


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #19020|review?                     |review-
               Flag|                            |

------- Comment #5 from eric at webkit.org  2008-02-09 13:26 PDT -------
(From update of attachment 19020)
Looks like you have tabs in Document.cpp

Document:: functions don't need to use Document:: to reference static methods
in the same class.

Since you're changing method behavior in Element, you will need to add tests
for the changed behavior.  (Similar to what was added by bug 16833.)  One
probably which will probably stop this bug as well is that createElement calls
createElementNS (caused the regression that caused bug 16833 to get rolled
out).  Likewise setAttribute might be calling setAtributeNS.  That means that
this patch would not only need to test createElementNS and setAttributeNS, but
also createElement and setAttribute (it's the lack of testing of those two
which is currently blocking bug 16833 from completion).

r- w/o more test cases to prove this is correct.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list