[Webkit-unassigned] [Bug 17220] Unnecessary dependency between PluginView and PluginDatabase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 17:25:50 PST 2008


------- Comment #5 from jhoneycutt at apple.com  2008-02-08 17:25 PDT -------
(From update of attachment 19010)
The call to PluginDatabase::installedPlugins() in PluginView::create() can't be
made without making PluginView aware of PluginDatabase. Doesn't that just move
the dependency around?

I think the change is still OK to make, but this needs some work:

+        PluginView* create(Frame* parentFrame, const IntSize&, Element*
element, const KURL& url, const Vector<String>& paramNames, const
Vector<String>& paramValues, const String& mimeType, bool loadManually);

This needs to be static.

PluginView should include PluginDatabase.h.

PluginDatabase.h shouldn't include PluginView.h, but will then require KURL.h.
You can then remove the "class KURL;" declaration.

The ChangeLog entry should be updated.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list