[Webkit-unassigned] [Bug 16924] Shared PluginDatabase, PluginPackage, and PlugInInfoStore Implementations

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16924


jhoneycutt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18989|review?                     |review+
               Flag|                            |




------- Comment #25 from jhoneycutt at apple.com  2008-02-07 17:45 PDT -------
(From update of attachment 18989)
Looks good to me. Few small comments:

+/* Methods for dealing with loadable modules */

We prefer // style comments.

+ * Copyright (C) 2008 Collabora, LTd. All rights reserved.

Typo: LTd.

+String pathGetFileName(const String& path)
+{
+    notImplemented();
+    return String();
+}
+
+bool unloadModule(PlatformModule module)
+{
+    notImplemented();
+    return false;
+}

No need to name the args here.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.