[Webkit-unassigned] [Bug 17172] Refactor platform checks in ScrollView.h

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17172


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




------- Comment #6 from jmalonzo at gmail.com  2008-02-07 02:29 PDT -------
(In reply to comment #5)
> (From update of attachment 18957 [edit])
> r=me
> It's unfortunate we now have 3 copies of these functions. I would have
> preferred a single copy either in a shared ScrollView.cpp file with a proper
> ifdef or as an inline in the header file (not in the class definition, though).

Hi Darin

Thanks. I agree with you. If you want you can r- it for now and i'll try to
come up with an updated patch.

> I feel the same way about other copied and pasted code that's in multiple
> platform files.

I will keep that in mind - thanks.

Regards


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.