[Webkit-unassigned] [Bug 16924] Shared PluginDatabase, PluginPackage, and PlugInInfoStore Implementations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 17:05:05 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16924





------- Comment #15 from mrowe at apple.com  2008-02-04 17:05 PDT -------
I've been looking at this and I think the first step should be:
PluginDatabaseWin -> PluginDatabase
PluginPackageWin -> PluginPackage
PlugInInfoStore -> PluginInfoStore (I'm not sure whether we want Plugin or
PlugIn, but either way I think we should be consistent about this while we're
renaming things)

It should also move the PluginInfoStore header into WebCore/plugins from
WebCore/platform, and the mac and qt implementations of PlugInInfoStore into
plugins/{mac,qt}.

Using do-webcore-renames will result in
WebCore/plugins/win/PluginDatabaseWin.cpp being renamed to
WebCore/plugins/win/PluginDatabase.cpp when we'll probably want it to
eventually end up staying at the original location and only containing the
Windows-specific bits of code.  I think it would be fine to have it renamed
briefly and then move it out of plugins/win/ into plugins/ in a later revision,
which can also move the Windows-specific bits back to PluginDatabaseWin.cpp.

Does this sound like a reasonable first step?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list