[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 11:41:01 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16979


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18835|review?                     |review-
               Flag|                            |




------- Comment #39 from aroben at apple.com  2008-02-04 11:41 PDT -------
(From update of attachment 18835)
Index: WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h
===================================================================
--- WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h    
(revision 29726)
+++ WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h    
(working copy)
@@ -23,6 +23,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */

+#include "config.h"

This is wrong. We only include config.h from source files, not from header
files. I don't think the #if PLATFORM(CG) in this file is needed anymore now
that it has a CG-specific name. Ditto for
GraphicsContextPlatformPrivateCairo.h.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list