[Webkit-unassigned] [Bug 17175] Use of C++ compiler flags in CFLAGS

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17175





------- Comment #3 from alp at atoker.com  2008-02-04 08:43 PDT -------
(From update of attachment 18908)
>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 29961)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2008-02-04  Rodney Dawes  <dobey at wayofthemonkey.com>
>+
>+	Reviewed by NOBODY (OOPS!!)
>+
>+	Only use -fno-rtti and $(SYMBOL_VISIBILITY_INLINES) with
>+	global_cppflags	as gcc complains they aren't valid for C
>+	Add -I$(srcdir)/WebCore to global_cppflags to get the right config.h
>+
>+	* GNUmakefile.am:
>+
> 2008-02-04  Alp Toker  <alp at atoker.com>
> 
>         Rubber-stamped by Mark Rowe.
>Index: GNUmakefile.am
>===================================================================
>--- GNUmakefile.am	(revision 29961)
>+++ GNUmakefile.am	(working copy)
>@@ -47,9 +47,11 @@ EXTRA_DIST :=
> 
> #
> # Global flags to CPP
>-global_cppflags :=
>+global_cppflags := \
>+	$(SYMBOL_VISIBILITY_INLINES)

cppflags is for preprocessor options, not C++ flags. This won't help.

Better solution is to clean up the flags and layout of the build modules.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.