[Webkit-unassigned] [Bug 17124] Use a script to make style more consistent throughout WebCore/JavaScriptCore

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17124


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alp at atoker.com




------- Comment #8 from alp at atoker.com  2008-02-01 17:06 PDT -------
(In reply to comment #7)
> As much as I would love it to be, this was not meant to be a complete fix for
> all style.  I appreciate you pointing out the cases I missed, I'll see if I can
> enhance the script.

Understood, running the whole codebase through astyle would probably be a much
larger diff.

I looked over the changes a bit and noticed one more thing. Bundled code like
WebCore/platform/image-decoders/zlib shouldn't be modified otherwise it'll
diverge from the upstream project and become difficult to track our local
changes with diff.

I think this might also apply to things like npapi.h. It's quite useful to be
able to diff our npapi.h against Mozilla's to track what changes we have.


Oops:

-         range if this entry defines a range, OR the *signed* offset to the
+         range if this entry defines a range, OR the* signed* offset to the

-  // REQUIRES: lock_ is *not* held.
+  // REQUIRES: lock_ is* not* held.

-// avoid having to turn all the quote marks into " as we would have to.
+// avoid having to turn all the quote marks into& quot; as we would have to.



I think changes to comments like this make them ambiguous:

-    // Returns the DOM ownerDocument attribute. This method never returns
NULL, except in the case 
+    // Returns the DOM ownerDocument attribute. This method never returns 0,
except in the case
     // of (1) a Document node or (2) a DocumentType node that is not used with
any Document yet. 
     virtual Document* ownerDocument() const;

^ The original comment is very clear at explaining that the function will
return a NULL pointer. The updated text is ambiguous -- it now sounds to me
like the function will return a an attribute, but the attribute will have value
"0".

So there is a loss of delicate semantics here and in a bunch of other places.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.