[Webkit-unassigned] [Bug 17229] Inspector should show properties of all JS objects in Console

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17229


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26310|review?                     |review-
               Flag|                            |




------- Comment #11 from timothy at hatcher.name  2008-12-30 06:57 PDT -------
(From update of attachment 26310)
Patch looks great! Some minor comments. r- for ow for some clean up.

> -                formattedResult.appendChild(formatForConsole(parameters[i]));
> +                formattedResult.appendChild(WebInspector.console._format(parameters[i]));

Why this change? The formatForConsole function just calls
WebInspector.console._format.

> +        if (x instanceof Node) {
> +            while (this.titleElement.firstChild) {
> +                this.titleElement.removeChild(this.titleElement.firstChild);
> +            }

You should use this.titleElement.removeChildren() instead of the while loop (a
prototype extension we have in utilities.js.)

> +        }
> +        else {

The "else {" should be on the previous line, so it is "} else {".

> +.console-formatted-object .section, .console-formatted-node .section {
> +  position: static;
> +}
> +

There should be 4 spaces here for the indent, not 2.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.