[Webkit-unassigned] [Bug 22750] [gtk] webkit up to r39121 crash on image urls like http:///sitename.com

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 24 18:04:41 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22750


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26238|review?                     |review-
               Flag|                            |




------- Comment #8 from zecke at selfish.org  2008-12-24 18:04 PDT -------
(From update of attachment 26238)
Please see http://webkit.org/coding/contributing.html and attach a new version
with a ChangeLog and an applyable patch.



> --- ResourceHandleSoup.cpp	2008-12-24 13:16:59.000000000 -0400
> +++ ResourceHandleSoup.cpp.new	2008-12-24 13:18:07.000000000 -0400
> @@ -335,7 +335,8 @@
>  
>      if (equalIgnoringCase(protocol, "data"))
>          return startData(urlString);
> -    else if (equalIgnoringCase(protocol, "http") || equalIgnoringCase(protocol, "https"))
> +    else if ( (equalIgnoringCase(protocol, "http") || equalIgnoringCase(protocol, "https") ) &&
> +                SOUP_URI_VALID_FOR_HTTP(soup_uri_new(urlString.utf8().data())))
>          return startHttp(urlString);


why did you decide to do this check here and not within startHttp? Is there
anyone else calling startHttp?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list