[Webkit-unassigned] [Bug 22624] [SOUP][GTK] Need API to get SoupSession from WebKit.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22624





------- Comment #6 from zecke at selfish.org  2008-12-24 14:05 PDT -------
(In reply to comment #5)
> Created an attachment (id=26240)
 --> (https://bugs.webkit.org/attachment.cgi?id=26240&action=view) [review]
> API to retrieve the soup session from the view #2
> 
> (In reply to comment #4)
> > (From update of attachment 26230 [review] [review])
> > General comments:
> >   - Coding Style, sepcially brackets on the if/else :)
> Updated to correct the coding style.
> 
> >   - on QtWebKit we allow to have something like a SoupSession per WebView...
> > would that make sense as well? E.g. sometimes you do not want two different
> > WebView to share the same cookie pool? If we want that the WebView should hold
> > a SoupSession and there should be one default session so by default every
> > WebView is sharing this session?
> That is actually the plan, and we discussed this a bit already. We figured it
> would be good to allow for it in the API, by having a view specific function,
> and in a second step add the logic for individual sessions and another
> function.


For the QtWebKit port we have added the necessary Document* pointers to be able
to get the QNetworkManager of the the QWebView. What I probably tried to
say/encourage is that newly created code should try to get the SoupSession
through the (Document->ChromeClient->WebKitWebPage). Whenever we decide to
allow to set a per session SoupSession we only have to change WebKitWebPage and
the rest will be fine. I think it should be little work to do that right from
the start.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.