[Webkit-unassigned] [Bug 18310] Acid3 gets segmentation fault with pango

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18310





------- Comment #11 from zecke at selfish.org  2008-12-24 04:30 PDT -------
(From update of attachment 26232)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 39457)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2008-12-23  Hiroyuki Ikezoe  <poincare at ikezoe.net>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=18310
> +
> +        * platform/graphics/gtk/SimpleFontDataPango.cpp:
> +        (WebCore::SimpleFontData::determinePitch): Do not invoke
> +        isFixedPitch() the font is a custom font.

                         ^
                       when to be inserted?



>  2008-12-23  Darin Adler  <darin at apple.com>
>  
>          Reviewed by John Sullivan.
> Index: WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp
> ===================================================================
> --- WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp	(revision 39456)
> +++ WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp	(working copy)
> @@ -116,7 +116,10 @@ bool SimpleFontData::containsCharacters(
>  
>  void SimpleFontData::determinePitch()
>  {
> -    m_treatAsFixedPitch = m_font.isFixedPitch();
> +    if (isCustomFont())
> +        m_treatAsFixedPitch = false;
> +    else
> +        m_treatAsFixedPitch = m_font.isFixedPitch();


I prefer the flow of the Windows code (win/SimpleFontDataWin.cpp) a lot more.

    // unlikely event
    if (isCustomFont()) {
        m_treatAsFixedPitch = false;
        return;
    }

    // business as usual...
    m_treatAdFixedPitch = m_font.isFixdPitch();


with the above it looks like both case are equal... which as of 2008 they are
not. Would you mind to change the code?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.