[Webkit-unassigned] [Bug 22902] RenderPath clean-up for strokeBoundingBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22902


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26188|                            |review+
               Flag|                            |




------- Comment #9 from zimmermann at kde.org  2008-12-21 15:14 PDT -------
(From update of attachment 26188)
This looks perfectly fine, r=me. Please fix two issues, before landing:

> Index: WebCore/platform/graphics/StrokeStyleApplier.h
> +
> +    protected:
> +        virtual ~StrokeStyleApplier() {}
Also add a protected constructor: "StrokeStyleApplier() {}" here.

> Index: WebCore/platform/graphics/cg/PathCG.cpp
> +static CGContextRef createScratchContext()
> +{
> +    CGContextRef contextRef = 0;
> +    if (!contextRef) {
> +        CFMutableDataRef empty = CFDataCreateMutable(NULL, 0);
> +        CGDataConsumerRef consumer = CGDataConsumerCreateWithCFData(empty);
> +        contextRef = CGPDFContextCreate(consumer, NULL, NULL);
> +        CGDataConsumerRelease(consumer);
> +        CFRelease(empty);
> +
> +        CGFloat black[4] = {0, 0, 0, 1};
> +        CGContextSetFillColor(contextRef, black);
> +        CGContextSetStrokeColor(contextRef, black);
> +    }
> +    return contextRef;
> +}

The if (!contextRef) case should be removed, it's always true.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.