[Webkit-unassigned] [Bug 22898] [GTK] Patch to complete GtkPrint API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22898


colin at colino.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26119|0                           |1
        is obsolete|                            |
  Attachment #26145|                            |review?
               Flag|                            |




------- Comment #11 from colin at colino.net  2008-12-19 09:56 PDT -------
Created an attachment (id=26145)
 --> (https://bugs.webkit.org/attachment.cgi?id=26145&action=view)
updated patch that fixes CodingStyle

Hi,

Here's an updated patch that fixes the mentioned style issues. Sorry about
indentations, my editor has a tendancy to replace 8 spaces with 1 tab and I
usually prefer this coding style, so I let that be :) I doubled checked them
this time.

About NULL usage in c++, I left them as is because I've noticed lots of NULLs
in other cpp files, and I'm not sure 0x0 would be nicer... Feel free to tell me
what you'd prefer if you really prefer I don't add NULLs :)

I've left the API in webframe.h, I don't mind an extra delay with this patch,
and OTOH i'd like to have a defined API - there's another place where I could
use it, a future Claws Mail plugin.

Thanks!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.