[Webkit-unassigned] [Bug 22880] Convert javascript Number Object or Boolean Object to Qt types in QtWebKit.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 18 05:35:11 PST 2008


tavestbo at trolltech.com changed:

           What    |Removed                     |Added
  Attachment #26056|review?(tavestbo at trolltech.c|review-
               Flag|om)                         |

------- Comment #2 from tavestbo at trolltech.com  2008-12-18 05:35 PDT -------
(From update of attachment 26056)
> +    // if hint is const QVariant& and type is Object, 
> +    // because the visitedObjects check at the beginging of this function,
> +    // make sure it's handled as QVariantMap upon the first time entering this function
> +    if (hint == (QMetaType::Type) qMetaTypeId<QVariant>() && type == Object)
> +        hint = QMetaType::QVariantMap;

I think we should remove the object from the visitedObjects when recursing with
the auto-detect flag instead.

>          case QMetaType::QVariantMap: 
> +                // Javascript built-in Number and Boolean object don't have properties,
> +                // convert them to double and bool respectively

Some auto-tests for this would be nice.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list