[Webkit-unassigned] [Bug 22614] Need to add Win32 implementation of ThreadSpecific.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22614





------- Comment #7 from jianli at chromium.org  2008-12-17 16:22 PDT -------
Thanks for pointing this out. I've fixed this problem. Please review my change
again. Sorry for taking so long to reply since I am just back from a trip.

(In reply to comment #5)
> (From update of attachment 25731 [review])
> Sorry, I pasted a wrong MSDN link, it was supposed to be
> <http://msdn.microsoft.com/en-us/library/ms686997(VS.85).aspx>.
> 
> MSDN suggests calling TlsFree from DLL_PROCESS_DETACH, and it is indeed OK to
> call it manually, or even not to call it at all - but I'm not talking about
> leaking TLS keys. The problem is about leaking TLS data of each thread. In
> pthread implementation of this class, destroy() is called automatically for
> each ThreadSpecific object on thread exit, because the callback is registered
> by pthread_key_create() - but nothing calls destroy() in this patch.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.