[Webkit-unassigned] [Bug 22893] get_accParent should try to retrieve parent AccessibilityObject, before calling upon window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22893


jhoneycutt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26081|review?                     |review-
               Flag|                            |




------- Comment #3 from jhoneycutt at apple.com  2008-12-17 14:27 PDT -------
(From update of attachment 26081)

>  
> +    AccessibilityObject* parentObj = m_object->parentObjectUnignored();
> +
> +    if (parentObj) {
> +        *parent = static_cast<IDispatch*>(wrapper(parentObj));
> +        (*parent)->AddRef();
> +        return S_OK;
> +    }
> +
>      return WebView::AccessibleObjectFromWindow(m_object->topDocumentFrameView()->hostWindow()->platformWindow(),
>          OBJID_WINDOW, __uuidof(IAccessible), reinterpret_cast<void**>(parent));
>  }

Our coding style prefers early returns, so this would be better written as:

if (!parentObject) {
    return
WebView::AccessibleObjectFromWindow(m_object->topDocumentFrameView()->hostWindow()->platformWindow(),
        OBJID_WINDOW, __uuidof(IAccessible), reinterpret_cast<void**>(parent));
}
*parent = static_cast<IDispatch*>(wrapper(parentObj));
(*parent)->AddRef();
return S_OK;

The change looks correct, but it will need a layout test for the new behavior.
r- for this reason.

Thanks for the patch, Jonas!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.