[Webkit-unassigned] [Bug 22755] Next step to Timers in Workers: moving timer code from other places to DOMTimer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22755


dimich at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25991|0                           |1
        is obsolete|                            |
  Attachment #26084|                            |review?
               Flag|                            |




------- Comment #5 from dimich at chromium.org  2008-12-16 20:14 PDT -------
Created an attachment (id=26084)
 --> (https://bugs.webkit.org/attachment.cgi?id=26084&action=view)
updated patch

Changed code per feedback from Darin.

I've moved timeoutsMap back to Document (undoing the part of the change) since
making it a global was not a good idea. It would have issues listed below,
which would unnecessary complicate the code, so I left it on the Document with
the idea to move it to ScriptExecutionContext very soon so Workers could use it
too:
- It would have to become ThreadSpecific in case of using in Workers
- It would have to become a map-of-maps or something else to separate IDs for
each window
- the code removing IDs from this map would be potentially a mem-leak-prone
code.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.