[Webkit-unassigned] [Bug 22879] Qt WebKit does not build on Windows with MSVC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 16 10:59:01 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22879


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26051|review?                     |review+
               Flag|                            |




------- Comment #2 from aroben at apple.com  2008-12-16 10:59 PDT -------
(From update of attachment 26051)
> +++ WebCore/platform/win/SystemTimeWin.cpp	(working copy)
> @@ -32,7 +32,11 @@
>  #if COMPILER(MINGW)
>  #include <float.h>
>  #define FLOAT_MAX FLT_MAX
> +#else
> +#if PLATFORM(QT)
> +#include <float.h>
>  #endif
> +#endif

I think using #elif would be better than introducing an extra level of nesting
here.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list