[Webkit-unassigned] [Bug 22022] [GTK] add a GeoLocation implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22022





------- Comment #19 from bolsinga at apple.com  2008-12-13 14:56 PDT -------
(In reply to comment #18)
> (From update of attachment 25984 [review])
> > diff -Naur a/WebCore/page/PositionError.h b/WebCore/page/PositionError.h
> 
> > -        TIMEOUT = 3
> > +        TIMEOUT = 3,
> > +        LOCATION_PROVIDER_ERROR = 4,
> > +        POSITION_NOT_FOUND_ERROR = 5
> > +
> >      };
> 
> This is plain wrong. The enum is matching the PositionError of the w3c
> geolocation API. You may not just add values to it...

Correct. These are up to the current spec, available at:

http://dev.w3.org/geo/api/spec-source.html

Please do not add these values to the enum.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.