[Webkit-unassigned] [Bug 22824] REGRESSION (r39206): 3 SVG pixel tests are failing on the Leopard pixel bot since r39206

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 13 12:47:56 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22824


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26002|                            |review?
               Flag|                            |




------- Comment #4 from zecke at selfish.org  2008-12-13 12:47 PDT -------
Created an attachment (id=26002)
 --> (https://bugs.webkit.org/attachment.cgi?id=26002&action=view)
Attempt to fix the regression

Ouch. The patch was changed to use USE(...) instead of ENABLE(...) and this one
item was not changed. When looking at the patch I didn't see the wrong #if. I
think the other part of the patch is right. I'm currently not on OSX and I'm
not able to run the pixel tests.

The change from:
  if(canUse)
    simple
  else
    complex
}

to
  if (canUse)
     return simple;
   return complex
}


looks okay and is matching other parts of the code...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list