[Webkit-unassigned] [Bug 22675] wxWidgets bindings don't have context menu support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22675





------- Comment #2 from kevino at theolliviers.com  2008-12-13 10:13 PDT -------
When I try this patch, I get an assert in
ContextMenuItem::ContextMenuItem(ContextMenuItemType type, ContextMenuAction
action, const String& title, ContextMenu* subMenu). 

Here's the assert message:

[Debug] 09:57:24: /BUILD/wxPython-src-2.8.8.1/src/common/menucmn.cpp(381):
assert "parentMenu != NULL" failed in wxMenuItemBase(): menuitem should have a
menu

It's possible that you built in release mode and thus didn't see this assert.
To build debug, you can run `WebKitTools/Scripts/set-webkit-configuration --wx
--debug`.

In any case, I had to give an r- to this patch because an assert like that
usually indicates that on at least one platform, the approach you're trying
won't work. I think what we need to do is mimic the GTK and QT ports here, and
have a PlatformMenuItemDescription structure that includes a native structure,
but the actual wxMenuItem(s) will be created in the ContextMenu::appendItem
call. The ContextMenuItem constructors themselves will just store and return
the values passed to them inside the PlatformMenuItemDescription struct.

Thanks for all your work on this!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.