[Webkit-unassigned] [Bug 22811] New: Underlinking in Programs_UnitTests (GTK+ build)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22811

           Summary: Underlinking in Programs_UnitTests (GTK+ build)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: awilliamson at mandriva.com


Since the unit tests were added to the webkit GTK+ build by zecke (in 39082),
there's a linking problem. If you build with -Wl,--as-needed -Wl,--no-undefined
(which strictly exposes underlinking issues), the build fails with the
following:

gcc -fno-strict-aliasing -O2 -Wall -W -Wcast-align -Wchar-subscripts
-Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef
-Wmissing-format-attribute -Wpointer-arith -Wwrite-strings
-Wno-unused-parameter -Wno-parentheses -fno-exceptions -fvisibility=hidden
-I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2
-I/usr/include/libpng12 -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -O2 -Wl,--as-needed
-Wl,--no-undefined -o Programs/.libs/UnitTests
WebKit/gtk/tests/Programs_UnitTests-main.o  ./.libs/libwebkit-1.0.so
/usr/lib64/libgtk-x11-2.0.so /usr/lib64/libgdk-x11-2.0.so
/usr/lib64/libatk-1.0.so /usr/lib64/libgio-2.0.so /usr/lib64/libpangoft2-1.0.so
/usr/lib64/libgdk_pixbuf-2.0.so /usr/lib64/libpangocairo-1.0.so
/usr/lib64/libcairo.so /usr/lib64/libpango-1.0.so /usr/lib64/libfreetype.so -lz
/usr/lib64/libfontconfig.so /usr/lib64/libgobject-2.0.so
/usr/lib64/libgmodule-2.0.so /usr/lib64/libglib-2.0.so 
WebKit/gtk/tests/Programs_UnitTests-main.o: In function `main':
/home/mandrake/rpm/BUILD/WebKit-r39090/WebKit/gtk/tests/main.c:27: undefined
reference to `g_thread_init'

The attached patch fixes this - I'm not sure if it's a correct fix, it may be
overbroad, but I couldn't find a LIBS variable which seemed more correct, so I
just added GLOBALDEPS_LIBS.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.