[Webkit-unassigned] [Bug 22798] Unitialized struct field in SVGFont.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22798


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25952|review?                     |review+
               Flag|                            |




------- Comment #3 from eric at webkit.org  2008-12-11 11:36 PDT -------
(From update of attachment 25952)
Just nits:
 1 2008-12-11  davemoore  <davemoore at google.com>

Should be:
 1 2008-12-11  David Moore  <davemoore at google.com>

(See my email on changelog entries sent to chrome-team last week.)

WARNING: NO TEST CASES ADDED OR CHANGED

can be removed and replaced when an explanation as to why it's untestable.

 5      Fixed https://bugs.webkit.org/show_bug.cgi?id=22798

Looks like a tab (or maybe just bad indentation)

Looks fine.  We could also have fixed this by adding a constructor to
SVGTextRunWalkerMeasuredLengthData (which would have possibly prevented future
such UMRs.


Marking r- for the nits.  Post another copy and I'll be happy to review and
land it for you.  Thanks for the fix!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.