[Webkit-unassigned] [Bug 22357] Crash when setting className via SVG className.baseVal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 11 11:27:42 PST 2008


------- Comment #8 from gwilson at google.com  2008-12-11 11:27 PDT -------
(In reply to comment #7)
> (In reply to comment #2)
> > May be related to https://bugs.webkit.org/show_bug.cgi?id=20651
> Definitely related.

There's one particular behavior in StyledElement::classAttributeChanged (which
was once part of parseMappedAttribute) -- it sets that it has a class first
(line 222), but doesn't actually set any mapped values if namedAttrMap doesn't
already exist.

(Looking in SVGEllipseElement, setting cX, cY, etc. values on baseValue doesn't
create this namedAttrMap, so that's probably why it doesn't exist.)

So, I think there are a few options here:
- Not set hasClass if namedAttrMap isn't set.  This doesn't seem like the right
approach because we *should* be setting both.
- Create namedAttrMap if it doesn't already exist.  This could be done via
createAttributeMap().  This seems like the right way, but I don't know all of
the background of namedAttrMap to know.

What's the best way to do this?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list