[Webkit-unassigned] [Bug 22795] favicons should be saved to webarchives

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22795


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |ddkilzer at webkit.org
                   |unassigned at lists.webkit.org |
             Status|NEW                         |ASSIGNED
  Attachment #25925|                            |review?
               Flag|                            |




------- Comment #1 from ddkilzer at webkit.org  2008-12-10 13:55 PDT -------
Created an attachment (id=25925)
 --> (https://bugs.webkit.org/attachment.cgi?id=25925&action=view)
Patch v1

Proposed patch.

A couple of notes:

- Should I expose a method in WebIconDatabasePrivate.h to disable the icon
database instead of using a WebIconDatabaseInternal method?  Or should I add
_applicationWillTerminate: to WebIconDatabaseInternal.h and make the header
Private so it is copied to PrivateHeaders?

- Similarly for the Windows LayoutTestController::setIconDatabaseEnabled(bool)
method, should I expose a WebIconDatabase::close() method instead of calling
shutDownWebKit()?

- I have not tried to compile the Windows code yet.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.