[Webkit-unassigned] [Bug 22665] Remove setCreatedByParser(bool) from the few elements that use it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 9 17:16:09 PST 2008


------- Comment #11 from jchaffraix at pleyo.com  2008-12-09 17:16 PDT -------
(In reply to comment #10)
> (From update of attachment 25896 [review])
> >  HTMLPlugInElement::HTMLPlugInElement(const QualifiedName& tagName, Document* doc)
> > -    : HTMLFrameOwnerElement(tagName, doc)
> > +    : HTMLFrameOwnerElement(tagName, doc, false)
> >      , m_NPObject(0)
> >  #endif
> I think you stumbled on a bug here.
> You should comment about the fact that this is strange.

I will before landing.

> You should consider filing a bug report.


> You consider thinking about what the symptom of the bug would be. What does
> HTMLFrameOwnerElement do differently when created by the parser? And then
> construct a test case. And then fix the bug.

I do not think there is changes at construction time. I think that the return
value of HTMLFrameOwnerElement::createdByParser() would modify some methods'
behaviour. I have done some investigation and the only method using it is
FrameLoader::updateHistoryForStandardLoad(). I will do some more research later
before closing this bug.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list