[Webkit-unassigned] [Bug 22757] break out text caret paint as enabled feature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 9 09:06:00 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22757


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25887|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-12-09 09:06 PDT -------
(From update of attachment 25887)
> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 39135)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2008-12-09  Cary Clark  <caryclark at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Add ENABLE_TEXT_CARET to permit the ANDROID platform
> +	to invalidate and draw the caret in a separate thread.
> +
> +        * wtf/Platform.h:
> +	Default ENABLE_TEXT_CARET to 1.

ChangeLog has tabs in it. This makes it harder to land the patch, because the
committer has to change the tabs to spaces. Please don't use tabs in WebKit
changes.

Patch otherwise looks fine. r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list