[Webkit-unassigned] [Bug 22037] QtLauncher robotization for testing purposes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22037


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24844|review?                     |review-
               Flag|                            |




------- Comment #5 from hausmann at webkit.org  2008-12-09 02:31 PDT -------
(From update of attachment 24844)
> Index: WebKit/qt/ChangeLog
> ===================================================================
> --- WebKit/qt/ChangeLog	(revision 37444)
> +++ WebKit/qt/ChangeLog	(working copy)
> @@ -1,3 +1,24 @@
> +2008-10-09  System User  <set EMAIL_ADDRESS environment variable>

Please add your real name and email address.

> --- WebKit/qt/QtLauncher/QtLauncher.pro	(revision 37432)
> +++ WebKit/qt/QtLauncher/QtLauncher.pro	(working copy)
> @@ -3,6 +3,9 @@ SOURCES += main.cpp
>  CONFIG -= app_bundle
>  CONFIG += uitools
>  DESTDIR = ../../../bin
> +INCPATH += $$PWD/../../../JavaScriptCore/wtf
> +LIBS += -L../../../JavaScriptCore/ 
> +LIBS += -lJavaScriptCore

I don't think we should use the WTF types outside of WebCore, so this should
not be necessary.

> +public slots:
> +    void loadNext()
> +    {
> +        QString qstr;
> +        if (getUrl(qstr)) {
> +            QUrl url(qstr, QUrl::StrictMode);
> +            if (url.isValid()) {
> +                m_stdOut<<"Loading "<<qstr<<" ......"<<endl;

Coding style, please put spaces between the arguments.

> +private:
> +    WTF::Vector<QString> m_urls;

I suggest the use of QStringList instead. This way we do not have to have to
pull in WTF or the static JavaScriptCore library.

The rest of the patch looks good, heads up :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.