[Webkit-unassigned] [Bug 22352] Annotating opcodes with length

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 8 16:43:42 PST 2008


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
  Attachment #25855|review?                     |review+
               Flag|                            |

------- Comment #4 from cwzwarich at uwaterloo.ca  2008-12-08 16:43 PDT -------
(From update of attachment 25855)

You introduced some trailing whitespace at the top of Opcode.cpp.

+    #define OPCODE_ID_SIZES(id, size) const int opcode_size_##id = size;

I prefer the style ##id_length to opcode_length_##id.

Other than that, r=me. I will apply these changes and land it tonight. Thanks
for doing this cleanup. There are still other uses of hardcoded opcode lengths
in the code that you didn't catch, but I will make a separate bug for those.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list