[Webkit-unassigned] [Bug 22679] [GTK] Function Keys (F1 to F12) are not mapped

Mon Dec 8 15:52:05 PST 2008

https://bugs.webkit.org/show_bug.cgi?id=22679

eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25769|review?                     |review+
               Flag|                            |

------- Comment #5 from eric at webkit.org  2008-12-08 15:52 PDT -------
(From update of attachment 25769)
Looks fine.  It would have been easy to write as an if depending on GDK_F1 to
GDK_F24 being in the same order.  Something like:

if (code >= GDK_F1 && code <= GDK_F24)
  return VK_F1 + (code - GDK_F1);

But it's also OK to have been explicit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.