[Webkit-unassigned] [Bug 22379] Make CSSOM use less memory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22379


koivisto at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #16 from koivisto at iki.fi  2008-12-06 17:46 PDT -------
(In reply to comment #15)
> (From update of attachment 25768 [review])
> > +    Vector<CSSProperty>::const_iterator it = findPropertyWithId(propertyID);
> 
> Something I always tell people who are working with Vector is that iterators
> are just pointers and thus I think it's unnecessary to use the typedef or use
> end() to indicate "not found". So I would have done:

I was planning to do an empty slot optimization but then decided that it is not
really needed. Use of iterators was a leftover from that.

>     const CSSProperty* property = findPropertyWithId(propertyID);

Done.

> I think we should change this function to take a HashSet and make a helper
> function to use with it. I think the function is *always* used with static
> sets.

Left as a future exercise.

> > +        m_implicit = other.m_implicit;
> >          m_value = other.m_value;

> Maybe you could land this change sepaarately?

Ok.

> Why not change this to use removePropertiesFromSet now? If you're going to add
> a comment, please mention the name of the function specifically.

It not fully equivalent though perhaps it should be. I didn't want to introduce
many behavioral changes.

Left as a future exercise.

> How did you test the impact on speed?

PLT seemed to show a slight progression.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.