[Webkit-unassigned] [Bug 22665] Remove setCreatedByParser(bool) from the few elements that use it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 11:46:01 PST 2008


jchaffraix at pleyo.com changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

------- Comment #3 from jchaffraix at pleyo.com  2008-12-05 11:46 PDT -------
Before replying to your comment, my goal is either harmonize the HTMLElements'
signature or tweak the factory generation using the .in file. The final goal is
to generate HTMLElementFactory so I am quite open on the path to choose.

(In reply to comment #2)
> (From update of attachment 25760 [review])
> It seems ugly to have to put those details into the .in file -- why not always
> have a setCreatedByParser function that's an inline that does nothing instead?

I don't think adding 20 or so empty setCreatedByParser methods is also an
improvement. I find the method setCreatedByParser to be artifical as it is
called just after the constructor was called so I would rather see the
constructor modified to take the createdByParser boolean parameter instead.
Unfortunately in both cases, we would not know which element use the
createdByParser information anymore.

I have chosen this way for 2 reasons: first it would avoid changing all
HTMLElements signature (or add the setCreatedByParser method) by just tweaking
the code generation for those required. Also removing setCreatedByParser means
removing XMLTokenizer::eventuallyMarkAsParserCreated.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list