[Webkit-unassigned] [Bug 22683] Improper calls to checkArgv function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 10:40:38 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22683


zandobersek at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25776|                            |review?
               Flag|                            |




------- Comment #1 from zandobersek at gmail.com  2008-12-05 10:40 PDT -------
Created an attachment (id=25776)
 --> (https://bugs.webkit.org/attachment.cgi?id=25776&action=view)
Fix of function calls

Fixed function calls

To explain a bit further, in the checkArgv function, shift is called twice on
the arguments array. If the second shift fails, the argument we search for is
not removed from the arguments array. Since it is not removed, scripts exit
with a complain, for instance, that the "--gtk" is an unknown option.

This fixes such problems on the Gtk+ port, but I am unsure if this behaviour is
acceptable on others.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list