[Webkit-unassigned] [Bug 22374] Need API to access favicons using the favicon URL.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 09:41:26 PST 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #25300|review?                     |review-
               Flag|                            |

------- Comment #4 from darin at apple.com  2008-12-05 09:41 PDT -------
(From update of attachment 25300)
I'm not sure I understand the use of the term "API" here. This is the internal
interface between WebCore and WebKit. I don't see a patch adding API to any
platform's WebKit.

A patch that adds an unused function is not a good idea.

Further, there's too much copied and pasted code here -- this should not just
be a copy of iconForPageURL; instead it should be factored so the code is
shared appropriately.

Because of these two issues I'm going to say review- for this version of the

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list