[Webkit-unassigned] [Bug 22656] tests document.write()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 16:01:36 PST 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #25746|review?                     |review-
               Flag|                            |

------- Comment #2 from darin at apple.com  2008-12-04 16:01 PDT -------
(From update of attachment 25746)
This test looks fine, but the patch needs to also include a ChangeLog entry.
Also, we prefer to have the "newline at end of file" unless there's a reason
not to have it.

Also, we prefer tests that cover a bit more per test. It's OK to have a test
that tests only this one targeted thing, but it's better to cover more per test
so our tests cover a lot of different cases and run quickly.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list