[Webkit-unassigned] [Bug 22564] Make HTML elements' constructors take a QualifiedName

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 14:00:05 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22564





------- Comment #8 from jchaffraix at pleyo.com  2008-12-04 14:00 PDT -------
(In reply to comment #7)
> (From update of attachment 25685 [review])
> Might as well make this one line:
>  static PassRefPtr<HTMLElement> objectConstructor(const QualifiedName&,
> Document* doc, HTMLFormElement*, bool createdByParser)
>  {
> -    RefPtr<HTMLObjectElement> object = new HTMLObjectElement(doc,
> createdByParser);
> +    RefPtr<HTMLObjectElement> object = new HTMLObjectElement(objectTag, doc,
> createdByParser);
>      return object.release();
>  }
> 

Good catch! However I will need to sort out what to do with those
createdByParser boolean before rolling out HTMLElementFactory (there is
currently 2 syntax that should be merged somehow). I will keep this line as-is
for now.

> otherwise looks great!

Thanks!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list