[Webkit-unassigned] [Bug 22579] Avoid high-level WebCore types under platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 13:26:46 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22579





------- Comment #3 from finnur.webkit at gmail.com  2008-12-04 13:26 PDT -------
Thanks for the review, Darin. One question regarding Vector<Int>:

The function document()->renderedRectsForMarkers() returns a Vector<IntRect>.
If we want Vector<Int> instead we would have to either convert from one vector
type to another (inefficient) or add an implementation of
renderedRectsForMarkers that returns the new type (adding complexity).

However, IntRect makes more sense to me when I think about it because you might
want to make the height of the tickmark on the scrollbar relative to the height
of the rendered rect. 

Does that make sense? I will update the patch to address the review comments
(except for this unresolved question).

PS. Sorry about the style violations - I still find it hard to switch from one
style to another; old habits die hard. :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list