[Webkit-unassigned] [Bug 22650] Make most of SVGMatrix bindings generated again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 12:35:32 PST 2008


eric at webkit.org changed:

           What    |Removed                     |Added
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

------- Comment #2 from eric at webkit.org  2008-12-04 12:35 PDT -------
I don't like this being a one-line "hack" without explanation.  It seems from
looking at the bugs, that SVGMatrix is effectively read-only/copy-on-write, yet
our AffineTransform is not.

Lots of ways we could have solved this, besides making custom bindings methods
(which I think was the wrong solution).  One of them would have been to have
made an SVGMatrix stack object wrapper class around AffineTransform (different
from how we used to have SVGMatrix heap objects) and to have used that as the
PODType.  multiply() etc. on that intermediate binding layer would have
contained this "copy instead of mutate" logic which Niko put in the bindings
with the old patch.

I'm not sure I understand how your solution works?

Why does just not "writing back" to wherever the matrix came from solve things

element.matrix = z;
var a = element.matrix;
var b = a.multiply(10);
assert(element.matrix == z);
assert(a == element.matrix);
assert(a != b);

Seems your solution would solve the first assert, but not the second two?  I
must be missing something.   I should look at the generated code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list