[Webkit-unassigned] [Bug 20953] Rework the Font handling in QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20953


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23592|review?(hyatt at apple.com)    |review+
               Flag|                            |




------- Comment #18 from darin at apple.com  2008-12-04 09:18 PDT -------
(From update of attachment 23592)
Moving to a separate file seems fine.

> +/**

We don't use that double-star format.

> + * This file is part of the html renderer for KDE.

You can leave this out of the new file.

> + * Copyright (C) 1999 Lars Knoll (knoll at kde.org)
> + *           (C) 1999 Antti Koivisto (koivisto at kde.org)
> + *           (C) 2000 Dirk Mueller (mueller at kde.org)
> + * Copyright (C) 2003, 2006 Apple Computer, Inc.
> + * Copyright (C) 2008 Holger Hans Peter Freyther

None of the code you're moving is covered by the older copyrights (older than
2003); it's all new stuff. So you can omit those older copyright notices from
this new file.
> +    return data;
> +}
> +
> +
> +
> +}

We just use one blank line in places like this, not 3.

r=me on moving this code


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.