[Webkit-unassigned] [Bug 22379] Make CSSOM use less memory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 3 13:30:47 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22379


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25721|review?                     |review+
               Flag|                            |




------- Comment #11 from darin at apple.com  2008-12-03 13:30 PDT -------
(From update of attachment 25721)
> Index: WebCore/css/CSSSelectorList.cpp
> ===================================================================
> --- WebCore/css/CSSSelectorList.cpp	(revision 0)
> +++ WebCore/css/CSSSelectorList.cpp	(revision 0)
> @@ -0,0 +1,55 @@
> +#include "config.h"
> +
> +#include "CSSSelectorList.h"

This needs a license header. Also, we don't usually put spaces between these
two includes.

> Index: WebCore/css/CSSSelectorList.h
> ===================================================================
> --- WebCore/css/CSSSelectorList.h	(revision 0)
> +++ WebCore/css/CSSSelectorList.h	(revision 0)
> @@ -0,0 +1,31 @@
> +#ifndef CSSSelectorList_h
> +#define CSSSelectorList_h

This needs a license header.

It's a little annoying that this class is called "List" when that so often
means linked list, but I think that's the best name.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list