[Webkit-unassigned] [Bug 22620] Use ActiveDOMObject as base class for DOMTimers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22620





------- Comment #6 from dimich at chromium.org  2008-12-03 12:24 PDT -------
(In reply to comment #4)
Thanks for review! Upcoming patch addresses all the comments.

> I don't know we have any tests for timers and navigation.

I'll add one soon if we don't - made a note for myself :-)

> +                if (Document* document = frame->document())
> +                    document->suspendActiveDOMObjects();
> 
> I don't think we can have document-less frames now, even though there's still a
> lot of code that makes this check.

I thought of replacing with ASSERT but there are so many places around that do
exactly the same that it feels a blanket change could be done, in a separate
patch.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.