[Webkit-unassigned] [Bug 22614] Need to add Win32 implementation of ThreadSpecific.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22614


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25697|review?                     |review-
               Flag|                            |




------- Comment #2 from ap at webkit.org  2008-12-03 00:24 PDT -------
(From update of attachment 25697)
> -#if USE(PTHREADS) || PLATFORM(WIN)
> +#if USE(PTHREADS) || PLATFORM(WIN) || PLATFORM(WIN_OS)

No need to keep PLATFORM(WIN), because it can only be set if PLATFORM(WIN_OS)
is set.

> +#if USE(PTHREADS) || PLATFORM(WIN)
>      pthread_key_t m_key;

Similarly, I think this test should be just USE(PTHREADS).

> +template<typename T>
> +inline void ThreadSpecific<T>::destroy(void* ptr)

What calls destroy() when a thread exits? Per
<http://msdn.microsoft.com/en-us/library/ms686801(VS.85).aspx>, data kept in
per-thread storage must be destroyed manually in a DLL_THREAD_DETACH callback.

r-, because I think that per-thread data leaks.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.