[Webkit-unassigned] [Bug 22620] New: Use ActiveDOMObject as base class for DOMTimers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 3 00:23:37 PST 2008


           Summary: Use ActiveDOMObject as base class for DOMTimers
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dimich at chromium.org
                CC: ap at webkit.org

This allows to consolidate separate calls like
clearAllTimeouts/pauseTimeouts/resumeTimeouts into similar calls for
ActiveDOMObjects. That removes timeouts-specific clear/pause/resume code.
It also makes it unnecessary to unload timers into PausedTimeout 'containers'
on pause/resume - they can be paused/resumed in-place now, as ActiveDOMObjects.
This makes it possible to get rid of PausedTimeouts as a class.
Finally, the hash table that keeps mapping id->timeout is moved from
JSDOMWindow to Document to match the lifetime of DOMTimers.

This patch is a step (I'm trying to do one change at a time) towards making
timeouts available on Workers.
Next steps (preliminary, some need more discussion): 
1. Delete file PausedTimeouts.h,cpp from the build
2. Since there is no JS* objects in DOMTimer anymore, it can be moved from
bindings/js/ to lets say dom/
3. DOMTimer::fired() and JSDOMWindowBase::timerFired can be merged into one
method on DOMTimer
4. Create/removeTimeout methods can be moved from JSDOMWindowBase to
ScriptExecutionContext so they are available of Workers too. Move id->timer map
to SEC at the same time.
5. Make DOMTimer able to post/receive time events on threads different from
main UI one.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list