[Webkit-unassigned] [Bug 22611] Clean up run-javascriptcore-tests in preparation for adding --chromium support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 2 17:24:04 PST 2008
https://bugs.webkit.org/show_bug.cgi?id=22611
------- Comment #3 from eric at webkit.org 2008-12-02 17:24 PDT -------
(In reply to comment #2)
> (From update of attachment 25691 [review])
> > chdir "JavaScriptCore" or die "Can't find JavaScriptCore directory to build from";
> > my $result;
> > if (isAppleMacWebKit()) {
> > - $result = system "sh", "-c", 'xcodebuild -project JavaScriptCore.xcodeproj -target jsc "$@" | grep -v setenv && exit ${PIPESTATUS[0]}', "xcodebuild", @options, @ARGV;
> > + $result = system "sh", "-c", 'xcodebuild -project JavaScriptCore.xcodeproj -target jsc "$@" | grep -v setenv && exit ${PIPESTATUS[0]}', "xcodebuild", @options, @ARGV, @coverageSupportOptions;
> > } elsif (isAppleWinWebKit()) {
>
> Why is this not using buildXCodeProject?
>
It could, certainly. It is grepping out setenv. That's probably what we wnt
to do for all calls to xcodebuild, but I didn't want to make the decision at
this moment. I figure I'll come back in a later patch and abstract all calls
to xcodebuild to use buildXCodeProject() instead. buildXCodeProject also
should be made more robust to handle things like --64-bit, --universal, etc.
for all projects, instead of build-webkit having one-offs for all of these
standard build options.
We also should eventually probably break all of the building logic out of
webkitdirs.pm and into a separate WebKitBuildSupport.pm or something. Right
now prepare-ChangeLog pulls in all of the build support stuff which is silly.
:)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list