[Webkit-unassigned] [Bug 22108] REGRESSION: Animated gifs sometimes don't animate (wunderground.com weather radar)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 17:05:23 PST 2008


pkasting at google.com changed:

           What    |Removed                     |Added
         AssignedTo|webkit-                     |pkasting at google.com
                   |unassigned at lists.webkit.org |
             Status|NEW                         |ASSIGNED
  Attachment #25693|                            |review?(hyatt at apple.com)
               Flag|                            |

------- Comment #23 from pkasting at google.com  2008-12-02 17:05 PDT -------
Created an attachment (id=25693)
 --> (https://bugs.webkit.org/attachment.cgi?id=25693&action=view)
patch v1

hyatt and I have already chatted some on IRC about this patch.

This fixes animations by not deleting the decoder, meaning the loop count can
stay valid across frames.  I didn't actually determine for sure that this was
the problem in CG WebKit, but it was the problem in Chromium, and patching the
fix in here made the testcases seem to work in my Safari Win build.

It turns out the CG decoder was already doing a pretty good job of dropping
frames when their external references were released, and of deleting frames
internally during re-decoding, so it didn't suffer from the peak memory issues
Cairo/Chromium did, and the old "delete ImageDecoder" code wasn't really
necessary for it at all.  Unfortunately it also decodes from the beginning of
the stream more than it needs to, so it still uses far more CPU than it should
(i.e. this patch does not fix the underlying problem in bug 22280).  Perhaps
hyatt can use the framework in this patch to help address things.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list