[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #108 from soto at informatik.uni-kl.de  2008-12-02 03:33 PDT -------
(In reply to comment #103)
>  that's an absolutely necessary wrapper object that contains the
>  pure virtual function getGObjType(), and is tied in to the
>  DOM Object cache in GDOMBinding.cpp
> 
>  without that pure virtual function, the whole system collapses as
>  you cannot correctly typecast an object back to its proper c++
>  core object.

Let me address only this point because I have to leave in a few minutes. I read
your comments in the code about the "absolutely necessary getGObjType() virtual
method", and spent quite some time checking all code paths were it was
involved. It turns out that this method returns exactly the same GObject type
that is stored in the wrapping GObject. After checking the code quite
thoroughly, I found that, in practice, all getGObjType() was being used for,
was to carry information from the top of the toGDOM functions to the bottom of
those same functions. I changed the toGDOM functions to wrap the core objects
into GObjects right from the start, and so I could get rid of getGObjType()
alltogether.

Just look at the relevant portions (you surely know were to find them, no need
to compare) or, even better, run it. It runs here for sure, so certainly
getGObjType() was not so absolutely necessary.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.