[Webkit-unassigned] [Bug 22564] Make HTML elements' constructors take a QualifiedName

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22564


jchaffraix at pleyo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #3 from jchaffraix at pleyo.com  2008-12-01 16:27 PDT -------
Landed patch in r38881.

(In reply to comment #2)
> (From update of attachment 25609 [review])
> I find this pattern a bit strange:
> 
>      if (!MediaPlayer::isAvailable())
>          return new HTMLElement(tagName, doc);
> -    return new HTMLVideoElement(doc);
> +    return new HTMLVideoElement(videoTag, doc);
> 
> As antti pointed out before, that will break any uses of if
> (element->hasTagName(videoTag) static_cast<HTMLVideoElement*>(element)...
> 
> Agreed, we should always be using something like element->isVideoElement()
> instead.

This will also break <source> and <audio> which do not have a custom
isXXXElement() method. I have filed bug22578 about that to keep this
information easily available (especially since the broken pattern is used in
WebCore).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.