[Webkit-unassigned] [Bug 22505] Add a test to validate the event order for context clicks.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 1 15:26:07 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22505





------- Comment #3 from levin at chromium.org  2008-12-01 15:26 PDT -------
I thought the difference either in events sent for the different platforms was
odd but thought I must not know something due to my newbie status.  Here's the
survey that I did when looking at this test.

For Windows:
  Safari, Chromium, and Firefox all send a mousedown, then a mouseup, and then
a contextmenu event all with event.button = 2 for all three events.

  IE sends the mousedown, mouseup with event.button =2, and then a contextmenu
event with event.button = 0.

For OSX:

  Safari sends a mousedown and a contextmenu event all with event.button = 2.
  Firefox sends a mousedown, a contextmenu and then a mouseup event all with
event.button = 2.

It seems to me that the correct behavior is to 
  "send a mousedown, then a mouseup, and then a contextmenu event all with
event.button = 2 for all three events."

I'd be willing to change Safari on OSX to do this.  I'd modify 
    - (NSMenu *)menuForEvent:(NSEvent *)event in
WebKit/mac/WebView/WebHTMLView.mm
by adding
        coreframe->eventHandler()->mouseUp(event);
right after the coreframe->eventHandler()->mouseDown(event); line.

I'll check if the contextmenu event is sent, it the mouseup is handled and
mirror that behavior too (as well as add a regression test).

How does that sound?

PS fwiw, the mouseDown change was added by
http://trac.webkit.org/changeset/28585 to mirror other browsers.)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list