[Webkit-unassigned] [Bug 22561] Enable WML Support for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22561


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25615|review?                     |review-
               Flag|                            |




------- Comment #3 from aroben at apple.com  2008-12-01 13:09 PDT -------
(From update of attachment 25615)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 38852)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,11 @@
> +2008-11-30  Brent Fulgham  <bfulgham at gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add WML related files to Visual Studio projects.
> +
> +        * WebCore.vcproj/WebCore.vcproj:

You should mention the other changes you made to the vcproj file in the
ChangeLog, since the diffs are so hard to read.

> +				PreprocessorDefinitions="__WIN32__;ENABLE_DOM_STORAGE;ENABLE_OFFLINE_WEB_APPLICATIONS;ENABLE_SVG;ENABLE_SVG_ANIMATION;ENABLE_SVG_AS_IMAGE;ENABLE_SVG_USE;ENABLE_SVG_FOREIGN_OBJECT;ENABLE_SVG_FONTS;WEBCORE_CONTEXT_MENUS;ENABLE_VIDEO;ENABLE_WML;ENABLE_WORKERS;ENABLE_XSLT;ENABLE_XPATH"

WML support is disabled by default for all ports right now, so I don't think we
should turn it on by default for Windows.

The added files/include paths look fine.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.